Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using dotnet 9's save assembly api for debugging DI IL emit #98234

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

allantargino
Copy link
Contributor

@allantargino allantargino commented Feb 9, 2024

With the recent support of Assembly.Save() in .NET 9, now it is possible to debug/view the IL emitted by ILEmitResolverBuilder in the Dependency Injection library project, even when targeting newer versions of .NET (before, only .NET Framework target was possible)

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 9, 2024
@ghost
Copy link

ghost commented Feb 9, 2024

Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection
See info in area-owners.md if you want to be subscribed.

Issue Details

With the recent support of Assembly.Save() in .NET, now it is possible to debug/view the IL emitted by ILEmitResolverBuilder in Dependency Injection project, even when targeting newer versions of .NET.

Author: allantargino
Assignees: -
Labels:

area-Extensions-DependencyInjection, community-contribution

Milestone: -

@stephentoub stephentoub requested a review from buyaa-n February 9, 2024 20:39
…rosoft.Extensions.DependencyInjection.csproj

Co-authored-by: Austin Wise <AustinWise@gmail.com>
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

The failure unrelated and known

@buyaa-n buyaa-n merged commit 745baab into dotnet:main Feb 13, 2024
108 of 111 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-DependencyInjection community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants